8000 Fix #467: Spinners clear terminal output by danepowell · Pull Request #478 · acquia/cli · GitHub
[go: up one dir, main page]
Skip to content

Fix #467: Spinners clear terminal output #478

New issue 10000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2021
Merged

Fix #467: Spinners clear terminal output #478

merged 1 commit into from
Mar 14, 2021

Conversation

danepowell
Copy link
Contributor
@danepowell danepowell commented Mar 12, 2021 •
edited by grasmash
Loading

Motivation

Fixes #467

Proposed changes
Patch Acquia CLI to include symfony/symfony#40450, until that's merged and we can update to a new Symfony release that includes the fix.

Alternatives considered
Wait until the Symfony release and just suffer the bug.

Merge requirements

  • Bug, enhancement, or breaking change label applied
  • Manual testing by a reviewer

@danepowell danepowell added the bug Something isn't working label Mar 12, 2021
@danepowell danepowell requested review from grasmash and anavarre March 12, 2021 19:42
@grasmash grasmash merged commit 968d793 into acquia:master Mar 14, 2021
@glensc
Copy link
glensc commented Apr 5, 2021

@danepowell are you running composer update instead of composer require vendor/package, because the composer lock commit includes unrelated updates.

@danepowell
Copy link
Contributor Author

Yes, I run composer update. Maybe not strictly best practice from a dev process standpoint, but we have no other process for keeping dependencies up to date. We just added dependabot but that's only for security updates.

@glensc
Copy link
glensc commented Apr 5, 2021

@danepowell you should at least make two commits then:

@danepowell danepowell deleted the issue-467 branch September 22, 2021 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grasmash grasmash grasmash approved these changes

@anavarre anavarre Awaiting requested review from anavarre

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

On macOS 10.15.7 Catalina, any operation involving the spinner erases any previous output
3 participants
@danepowell @glensc @grasmash
0