CLI-1182: Improve Phar visibility for PRs #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh... right... this involves building untrusted code, hence pull_request instead of pull_request_target... but then we can't inject AWS credentials |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1725 +/- ##
=========================================
Coverage 91.42% 91.42%
Complexity 1807 1807
=========================================
Files 121 121
Lines 6475 6475
=========================================
Hits 5920 5920
Misses 555 555 ☔ View full report in Codecov by Sentry. |
|
Unfortunately there's no way to test this without the code being merged to HEAD first, so let's move this conversation to HEAD... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.