8000 SMQ-2602 - Delete domain by felixgateru · Pull Request #3328 · absmach/supermq · GitHub
[go: up one dir, main page]
Skip to content

SMQ-2602 - Delete domain#3328

Open
felixgateru wants to merge 5 commits intoabsmach:mainfrom
felixgateru:smq2602-delete-domain
Open

SMQ-2602 - Delete domain#3328
felixgateru wants to merge 5 commits intoabsmach:mainfrom
felixgateru:smq2602-delete-domain

Conversation

@felixgateru
Copy link
Contributor
@felixgateru felixgateru commented Jan 28, 2026

What type of PR is this?

What does this do?

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

@felixgateru felixgateru force-pushed the smq2602-delete-domain branch from 3ae7f8e to 878d91f Compare January 29, 2026 14:27
@codecov
Copy link
codecov bot commented Jan 29, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 38.67521% with 287 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.34%. Comparing base (cd31b1c) to head (54ee8cb).

Files with missing lines Patch % Lines
domains/delete_handler.go 0.00% 94 Missing ⚠️
channels/private/service.go 0.00% 55 Missing ⚠️
clients/private/service.go 0.00% 54 Missing ⚠️
groups/private/service.go 0.00% 54 Missing ⚠️
domains/service.go 0.00% 12 Missing ⚠️
domains/api/http/endpoint.go 63.63% 2 Missing and 2 partials ⚠️
domains/operations.go 0.00% 4 Missing ⚠️
channels/api/grpc/endpoint.go 75.00% 1 Missing and 1 partial ⚠️
channels/api/grpc/request.go 50.00% 1 Missing and 1 partial ⚠️
domains/api/http/requests.go 50.00% 1 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #3328       +/-   ##
===========================================
+ Coverage   53.21%   79.34%   +26.13%     
===========================================
  Files         312      114      -198     
  Lines       32771    13862    -18909     
===========================================
- Hits        17439    10999     -6440     
+ Misses      14255     2199    -12056     
+ Partials     1077      664      -413

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@felixgateru felixgateru force-pushed the smq2602-delete-domain branch from 3cdba62 to 54ee8cb Compare January 29, 2026 15:01
@felixgateru felixgateru marked this pull request as ready for review January 29, 2026 15:01
@felixgateru felixgateru requested a review from a team as a code owner January 29, 2026 15:01
@felixgateru
feat: delete domain
2012506 
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
@felixgateru
refactor: delete entity policies on domain delete
5f0fa1a 
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
@felixgateru
revert: revert change to makefile
d08ac01 
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
@felixgateru
chore: update mock files
0dbb736 
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
@felixgateru
ci: fix proto linting
e52e83e 
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
@felixgateru felixgateru force-pushed the smq2602-delete-domain branch from 54ee8cb to e52e83e Compare February 5, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature : Delete domain

1 participant

@felixgateru
0