Testing isolation #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help prevent dependency conflicts.
The testing tools depend on the library and on the chiseltest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates the testing tools and code from the pure library code. The advantage is that projects can now use Tydi-Chisel without the need to depend on chiseltest, preventing the conflicts that that might bring.
The project now contains two sub-projects:
library-> Tydi-Chisel packagetestingTools-> Tydi-Chisel-Test packageThese are both aggregated under the
rootproject, such thatsbtcommands will be executed in both sub-projects.The test code for the library lives in the testing package now for it uses the testing tools and circular dependencies are not an option.
Similarly, since the chiseltest dependency is changed to a testing depencency for the library package, reverse transpilation only works in a testing environment now.