8000 fix(initSpeech): scope click listener to one-off, namespaced handler to avoid external UI conflicts by amartincua · Pull Request #617 · ableplayer/ableplayer · GitHub
[go: up one dir, main page]
Skip to content

fix(initSpeech): scope click listener to one-off, namespaced handler to avoid external UI conflicts #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amartincua wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(initSpeech): scope click listener to one-off, namespaced handler to avoid external UI conflicts #617

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68ed09c
fix(initSpeech): namespace and single-shot click handler to preserve …
amartincua May 9, 2025
9685cbc
Update ableplayer.js
joedolson May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions build/ableplayer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7723,14 +7723,14 @@ var AblePlayerInstances = [];
// handle a click on anything, in case the user
// clicks something before they click 'play' or 'prefs' buttons
// that would allow us to init speech before it's needed
$(document).on('click',function() {
$(document).on('click.ableInitSpeech', function () {
var greeting = new SpeechSynthesisUtterance('Hi!');
greeting.volume = 0; // silent
greeting.rate = 10; // fastest speed supported by the API
thisObj.synth.speak(greeting);
greeting.onstart = function(e) {
// utterance has started
$(document).off('click'); // unbind the click event listener
$(document).off('click.ableInitSpeech'); // unbind the click event listener
}
greeting.onend = function(e) {
// should now be able to get browser voices
Expand All @@ -7756,7 +7756,7 @@ var AblePlayerInstances = [];
thisObj.synth.speak(greeting);
greeting.onstart = function(e) {
// utterance has started
$(document).off('click'); // unbind the click event listener
$(document).off('click.ableInitSpeech'); // unbind the click event listener
};
greeting.onend = function(e) {
// should now be able to get browser voices
Expand Down
0