Do not set grammar to None for new LlamaGrammar objects
#834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `grammar` attribute is written by `init()`, but that method always returns `None`, so `__init__()` would then discard the previously written object.
8c93cf8 to
cc0fe43
Compare
|
@mthuurne thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
LlamaGrammar.grammarattribute is written byinit(), but that method always returnsNone, so__init__()would then discard the previously written object.Note that
Llama.generate()will callLlamaGrammar.reset()before using the grammar, so it will also work fine without this change, butLlama.sample()does not call thereset()method.