8000 Fix: add missing exit_stack.close() to end of /v1/completions endpoint by gjpower · Pull Request #1795 · abetlen/llama-cpp-python · GitHub
[go: up one dir, main page]
Skip to content

Fix: add missing exit_stack.close() to end of /v1/completions endpoint #1795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix: add missing exit_stack.close() to end of /v1/completions endpoint #1795

wants to merge 1 commit into from

Conversation

gjpower
Copy link
Contributor
@gjpower gjpower commented Oct 14, 2024
  • /v1/completions endpoint was missing an exit_stack.close() call

This was causing the llama proxy lock to be retained until exit_stack is cleaned up by garbage collector

@Ian321 Ian321 mentioned this pull request Oct 15, 2024
Merged
@gjpower
Copy link
Contributor Author
gjpower commented Oct 15, 2024

#1798 supersedes this MR as I found thread starvation issue was not just due to improper closing of exit_stack but due to thread starvation from dependency pull of llama_proxy locking all worker threads

@gjpower gjpower closed this Oct 15, 2024
@gjpower gjpower mentioned this pull request Oct 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gjpower
0