8000 Fix : Runtime errors by shamitv · Pull Request #1630 · abetlen/llama-cpp-python · GitHub
[go: up one dir, main page]

Skip to content

Fix : Runtime errors #1630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Fix : Runtime errors #1630

merged 1 commit into from
Jul 31, 2024

Conversation

shamitv
Copy link
Contributor
@shamitv shamitv commented Jul 28, 2024

Fix : Runtime erors. Non-existent variables _stack and _lora_adapter were being accessed for destruction.

Closes #1631

@shamitv
Copy link
Contributor Author
shamitv commented Jul 28, 2024

This is proposed fix for following issue : #1631

Copy link
Contributor
@Smartappli Smartappli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ltoniazzi
8000
Copy link

Thanks, this should fix these Phi-3 models too!

@abetlen
Copy link
Owner
abetlen commented Jul 31, 2024

@shamitv thank you so much for the fix. LGTM

@abetlen abetlen merged commit 1f0b9a2 into abetlen:main Jul 31, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stack trace on API server
4 participants
0