8000 adding missing args in create_completion for functionary chat handler by skalade · Pull Request #1430 · abetlen/llama-cpp-python · GitHub
[go: up one dir, main page]
Skip to content

adding missing args in create_completion for functionary chat handler #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2024
Merged

adding missing args in create_completion for functionary chat handler #1430

merged 1 commit into from
May 8, 2024

Conversation

skalade
Copy link
Contributor
@skalade skalade commented May 5, 2024

Looks like in all cases where stream == False the create_completion function was missing the new args.

I was getting this error when querying functionary v2 on llama-cpp-server:

TypeError: create_completion() missing 2 required positional arguments: 'prompt' and 'grammar'

@jeffrey-fong
Copy link
Contributor

Thanks for this! 🙏

@abetlen abetlen merged commit 903b28a into abetlen:main May 8, 2024
@axel7083 axel7083 mentioned this pull request Aug 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skalade @jeffrey-fong @abetlen
0