8000 Detect Mixtral's slightly different format by lukestanley · Pull Request #1214 · abetlen/llama-cpp-python · GitHub
[go: up one dir, main page]
Skip to content

Detect Mixtral's slightly different format #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2024
Merged

Detect Mixtral's slightly different format #1214

merged 1 commit into from
Feb 23, 2024

Conversation

lukestanley
Copy link
Contributor
@lukestanley lukestanley commented Feb 23, 2024 •
edited
Loading

Currently in main Mixtral will not work reliably for chat completions because the slightly different Mixtral chat format string is not detected in the metadata, so this adds the right string and checks that too so it can then use the existing format_mistral_instruct method which does seem to work well enough.
I think this should help make using Mixtral more obvious.
I suspect this will address #1202
@abetlen

@abetlen abetlen merged commit 8584962 into abetlen:main Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abetlen abetlen abetlen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukestanley @abetlen
0