Add current state detail to minitest transition_from assertions #850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's useful when reviewing a failure to know which state you did get by firing the transition, not just the one you expected, as this can help with tracing down the error in the state machine. This brings the minitest helper closer to the output from the rspec version which already includes the actual state not just the expected one.
Author
|
Failure here from codeclimate seems overzealous - but I'm willing to try resolving it if a maintainer thinks there's merit in doing so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's useful when reviewing a failure to know which state you did get by firing the transition, not just the one you expected, as this can help with tracing down the error in the state machine. This brings the minitest helper closer to the output from the rspec version which already includes the actual state not just the expected one.