8000 fix: merge metadata appendArtifactToTask metadata #615 by flex-myeonghyeon · Pull Request #616 · a2aproject/a2a-java · GitHub
[go: up one dir, main page]
Skip to content

fix: merge metadata appendArtifactToTask metadata #615 #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
flex-myeonghyeon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

8000 fix: merge metadata appendArtifactToTask metadata #615 #616

flex-myeonghyeon wants to merge 1 commit into from
+17 −0

Conversation

@flex-myeonghyeon
Copy link
Contributor
@flex-myeonghyeon flex-myeonghyeon commented Jan 29, 2026 •
edited
Loading

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests pass
  • Appropriate READMEs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@gemini-code-assist
Copy link
Contributor
gemini-code-assist bot commented Jan 29, 2026

Summary of Changes

Hello @flex-myeonghyeon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug where metadata associated with task artifacts was not being correctly merged when an artifact was updated. The changes introduce functionality to combine metadata from existing and incoming artifact updates, ensuring that all relevant metadata is preserved and available on the updated artifact. This enhances the robustness of artifact management by preventing unintended metadata loss during updates.

Highlights

  • Metadata Merging: Implemented logic within the appendArtifactToTask utility method to correctly merge metadata from both existing and new artifacts when updating a task artifact, ensuring no data loss.
  • Test Coverage: Added new test cases to TaskManagerTest to verify that artifact metadata is properly merged and retained during the appendArtifactToTask operation, confirming the fix behaves as expected.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 29, 2026
View reviewed changes
Copy link
Contributor
@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds functionality to merge artifact metadata when appending to an existing artifact. The implementation in Utils.java correctly merges the metadata from the existing and new artifacts, and new tests in TaskManagerTest.java verify this behavior. My review includes a suggestion to improve the robustness of the implementation by ensuring the resulting metadata map is immutable, which aligns with the intended immutable nature of Artifact records.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@flex-myeonghyeon @mhyeon-lee
0