Add unittests #32
Add unittests #32
Conversation
|
I think, it would be better if Nik4Image class contained everything related to calculations and image building (including run function) and some separate function did argument parsing. This could make possible to use Nik4 as a python module. |
|
That's my plan for the next pull request but I did not want to change whole Nik4 in one go. |
|
Thanks for working on this! When you're done, write something, and I'll see if this can be merged :) There are also some conflicts, check them plz. |
|
I didn't remember that the pull request is still open. :-) At Geofabrik, I am currently working on a C++ port of Nik4, called Nik5, with the same features and behaviour in order to avoid using Mapnik's Python bindings. That's why I invested time into tests. |
This pull request add some basic unit test for the calculation of the map size, bounding box, scale etc. based on the command line arguments. The unit tests are not complete. Instead, this pull request aims to make the code testable by adding a new class Nik4Image. Otherwise this pull request would become larger than it already is.
This pull request depends on #30 but I am open to rebase it on any other bug fix commit which does the same as #30
See also #31