[Feature] Use stop on first failure for all resource validators

lindyhopchris · lindyhopchris · commit afc7de6e8124 · 2021-07-03T12:21:28.000+01:00
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -10,12 +10,12 @@ jobs:
   build:
 
     runs-on: ubuntu-latest
-    
+
     strategy:
       fail-fast: true
       matrix:
         php: ['7.4', '8.0']
-        laravel: ['^8.0']
+        laravel: ['^8.30']
 
     steps:
     - name: Checkout Code
@@ -38,6 +38,6 @@ jobs:
         timeout_minutes: 5
         max_attempts: 5
         command: composer install --no-suggest --prefer-dist -n -o
-        
+
     - name: Execute tests
       run: vendor/bin/phpunit
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,12 @@ All notable changes to this project will be documented in this file. This projec
   remains unchanged - both are authorized using the `view<RelationshipName>` method on the relevant policy.
 - The request class now has a `isCreatingOrUpdating()` helper method to determine whether the request is to create or
   updated a resource.
+- Add stop on first failure to all validators in the resource request class.
+
+### Changed
+
+- Minimum Laravel version is now `8.30`. This change was required to use the `$stopOnFirstFailure` property on Laravel's
+  `FormRequest` class.
 
 ## [1.0.0-beta.4] - 2021-06-02
 
diff --git a/composer.json b/composer.json
@@ -31,7 +31,7 @@
         "laravel-json-api/exceptions": "^1.0.0-beta.2",
         "laravel-json-api/spec": "^1.0.0-beta.1",
         "laravel-json-api/validation": "^1.0.0-beta.2",
-        "laravel/framework": "^8.0"
+        "laravel/framework": "^8.30"
     },
     "require-dev": {
         "laravel-json-api/hashids": "^1.0.0-beta.2",
diff --git a/src/Http/Requests/ResourceRequest.php b/src/Http/Requests/ResourceRequest.php
@@ -316,7 +316,7 @@ protected function createRelationshipValidator(ValidationFactory $factory): Vali
             $this->relationshipRules(),
             $this->messages(),
             $this->attributes()
-        );
+        )->stopOnFirstFailure($this->stopOnFirstFailure);
     }
 
     /**
@@ -338,7 +338,7 @@ protected function createDeleteValidator(ValidationFactory $factory): Validator
                 $this->attributes(),
                 method_exists($this, 'deleteAttributes') ? $this->deleteAttributes() : []
             )
-        );
+        )->stopOnFirstFailure($this->stopOnFirstFailure);
     }
 
     /**
