[Feature] Add isCreatingOrUpdating request helper method

lindyhopchris · lindyhopchris · commit c8d88b7da46a · 2021-07-03T10:50:45.000+01:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,8 @@ All notable changes to this project will be documented in this file. This projec
   actions were authorized via the single `showRelationship()` method. Adding the new `showRelated` method means
   developers can now implement separate authorization logic for these two actions if desired. Our default implementation
   remains unchanged - both are authorized using the `view<RelationshipName>` method on the relevant policy.
+- The request class now has a `isCreatingOrUpdating()` helper method to determine whether the request is to create or
+  updated a resource.
 
 ## [1.0.0-beta.4] - 2021-06-02
 
diff --git a/src/Http/Requests/FormRequest.php b/src/Http/Requests/FormRequest.php
@@ -125,6 +125,16 @@ public function isUpdating(): bool
         return $this->isMethod('PATCH') && $this->isNotRelationship();
     }
 
+    /**
+     * Is this a request to create or update a resource?
+     *
+     * @return bool
+     */
+    public function isCreatingOrUpdating(): bool
+    {
+        return $this->isCreating() || $this->isUpdating();
+    }
+
     /**
      * Is this a request to replace a resource relationship?
      *
diff --git a/src/Http/Requests/ResourceRequest.php b/src/Http/Requests/ResourceRequest.php
@@ -238,7 +238,7 @@ public function validatedForRelation()
      */
     protected function prepareForValidation()
     {
-        if ($this->isCreating() || $this->isUpdating()) {
+        if ($this->isCreatingOrUpdating()) {
             $this->assertSupportedMediaType();
             $this->validateResourceDocument();
         } else if ($this->isModifyingRelationship()) {

Original file line number	Diff line number	Diff line change
`@@ -238,7 +238,7 @@ public function validatedForRelation()`
`238`	`238`	`*/`
`239`	`239`	`protected function prepareForValidation()`
`240`	`240`	`{`
`241`		`- if ($this->isCreating() \|\| $this->isUpdating()) {`
	`241`	`+ if ($this->isCreatingOrUpdating()) {`
`242`	`242`	`$this->assertSupportedMediaType();`
`243`	`243`	`$this->validateResourceDocument();`
`244`	`244`	`} else if ($this->isModifyingRelationship()) {`