Rename jsonldContextTemplate → jsonldContext and remove jsonldValuesets from FHIRSchemaBase#234
Rename jsonldContextTemplate → jsonldContext and remove jsonldValuesets from FHIRSchemaBase#234
Conversation
Co-authored-by: litlfred <662242+litlfred@users.noreply.github.com>
✅ Deployment SuccessfulBranch:
Deployment completed successfully! The site is now live at the URL above. |
✅ Deployment SuccessfulBranch:
Deployment completed successfully! The site is now live at the URL above. |
…ent table Co-authored-by: litlfred <662242+litlfred@users.noreply.github.com>
The Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
❌ Deployment FailedBranch: Deployment failed. Please check the build log for details. |
❌ Deployment FailedBranch: Deployment failed. Please check the build log for details. |
|
build error @copilot |
…rmitted by SUSHI) Co-authored-by: litlfred <662242+litlfred@users.noreply.github.com>
... Fixed in commit |
✅ Deployment SuccessfulBranch:
Deployment completed successfully! The site is now live at the URL above. |
|
@copilot i still dont see extensions at: they should only be timestamps for one build, not multple |
The URL you linked ( On the PR branch the extensions are present on the three elements — visible in the JSON/XML formal view tabs of the StructureDefinition page. They cannot appear as rows in the element tree table because SUSHI explicitly rejects For the repeated timestamps: |
… Mappings tab Co-authored-by: litlfred <662242+litlfred@users.noreply.github.com>
Fixed in commit Added a
The Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
✅ Deployment SuccessfulBranch:
Deployment completed successfully! The site is now live at the URL above. |
✅ Deployment SuccessfulBranch:
Deployment completed successfully! The site is now live at the URL above. |
|
i dont see the mappings. @copilot |
The approach has already been updated in commit * fhirParent ^alias[0] = "fhir:parent"
* jsonldValuesets ^alias[0] = "jsonld:valuesets"
* jsonldContextTemplate ^alias[0] = "jsonld:contextTemplate"These are rendered as "Alternate Names" rows in the Detailed Descriptions tab of the StructureDefinition-FHIRSchemaBase page (e.g. https://worldhealthorganization.github.io/smart-base/branches/extend-fhir-schema-for-json-names/StructureDefinition-FHIRSchemaBase-definitions.html). The custom extension and |
|
still not good. please restart approach from scratch @copilot |
…N property names Co-authored-by: litlfred <662242+litlfred@users.noreply.github.com>
Restarted in commit Regarding the three fields that require a name mapping (FHIR name → JSON property name):
The colon in all three JSON property names is what forces the mapping to exist at all: FHIR/FSH element names cannot contain colons, so Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Co-authored-by: litlfred <662242+litlfred@users.noreply.github.com>
✅ Deployment SuccessfulBranch:
Deployment completed successfully! The site is now live at the URL above. |
✅ Deployment SuccessfulBranch:
Deployment completed successfully! The site is now live at the URL above. |
|
@copilot it has not changed. this is what i see: Formal Views of Profile ContentDescription of Profiles, Differentials, Snapshots and how the different presentations work.
Name | Flags | Card. | Type | Description & Constraints Filter:
-- | -- | -- | -- | --
FHIRSchemaBase | | 0..* | Base | FHIR Schema Base (SMART Guidelines)
resourceType | | 0..1 | string | Resource Type
resourceDefinition | | 0..1 | uri | Resource Definition
fhirParent | | 0..1 | string | FHIR Parent
jsonldContext | | 0..1 | string | JSON-LD Context
Documentation for this format
Key Elements TableDifferential TableSnapshot TableStatistics/ReferencesAll |
Co-authored-by: litlfred <662242+litlfred@users.noreply.github.com>
|
✅ Deployment SuccessfulBranch:
Deployment completed successfully! The site is now live at the URL above. |
✅ Deployment SuccessfulBranch:
Deployment completed successfully! The site is now live at the URL above. |
jsonldContextTemplateis renamed tojsonldContext(jsonld:contextin JSON).jsonldValuesetsis removed — it was a redundant summary of ValueSet references already encoded per-element and within thejsonld:contextobject itself.FHIRSchemaBase.fshjsonldValuesetselement and its mapping linejsonldContextTemplate→jsonldContext; updated JSON serialisation note (jsonld:contextTemplate→jsonld:context) and Mapping block accordinglyfhirParentandjsonldContextshort descriptions to include JSON property names directly in the element table Description column (e.g."FHIR Parent (JSON: fhir:parent)"), making them immediately visible without requiring the Mappings tab or tooltipsgenerate_logical_model_schemas.py_base_element_name_map: removedjsonldValuesetsentry; renamedjsonldContextTemplate→jsonldContextjsonld:valuesetsproperty; renamed context property key tojsonld:contextallOfoverlay: removedjsonld:valuesetsconst-pin; renamed context pin tojsonld:contextBefore / after (base element name map):
Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.