10BC0 Web Manifest: parsing the id member should strip the hash by marcoscaceres · Pull Request #28425 · WebKit/WebKit · GitHub
[go: up one dir, main page]
Skip to content

Web Manifest: parsing the id member should strip the hash #28425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2024
Merged

Web Manifest: parsing the id member should strip the hash #28425

merged 1 commit into from
May 14, 2024

Conversation

marcoscaceres
Copy link
Contributor
@marcoscaceres marcoscaceres commented May 11, 2024 •
edited by webkit-early-warning-system
Loading

4a635aa

Web Manifest: parsing the id member should strip the hash
rdar://127864531
https://bugs.webkit.org/show_bug.cgi?id=273991

Reviewed by Sihui Liu.

Strips the hash from the id member when parsing the Web Manifest.
Part of w3c/manifest#1122

* Source/WebCore/Modules/applicationmanifest/ApplicationManifestParser.cpp:
(WebCore::ApplicationManifestParser::parseId):
* Tools/TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
(TEST_F):

Canonical link: https://commits.webkit.org/278724@main

b34778d

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ⏳ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@marcoscaceres marcoscaceres self-assigned this May 11, 2024
@webkit-early-warning-system
Copy link
Collaborator
webkit-early-warning-system commented May 11, 2024 •
edited
Loading

EWS run on current version of this PR (hash b34778d)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ⏳ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@marcoscaceres marcoscaceres marked this pull request as ready for review May 12, 2024 04:30
@marcoscaceres marcoscaceres added the merge-queue Applied to send a pull request to merge-queue label May 14, 2024
@marcoscaceres
Web Manifest: parsing the id member should strip the hash
4a635aa 
rdar://127864531
https://bugs.webkit.org/show_bug.cgi?id=273991

Reviewed by Sihui Liu.

Strips the hash from the id member when parsing the Web Manifest.
Part of w3c/manifest#1122

* Source/WebCore/Modules/applicationmanifest/ApplicationManifestParser.cpp:
(WebCore::ApplicationManifestParser::parseId):
* Tools/TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
(TEST_F):

Canonical link: https://commits.webkit.org/278724@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Web-Manifest-parsing-the-id-member-should-strip-the-hash branch from b34778d to 4a635aa Compare May 14, 2024 00:42
@webkit-commit-queue
Copy link
Collaborator

Committed 278724@main (4a635aa): https://commits.webkit.org/278724@main

Reviewed commits have been landed. Closing PR #28425 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 4a635aa into WebKit:main May 14, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 14, 2024
@marcoscaceres marcoscaceres deleted the eng/Web-Manifest-parsing-the-id-member-should-strip-the-hash branch January 17, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szewai szewai szewai approved these changes

Assignees

@marcoscaceres marcoscaceres

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marcoscaceres @webkit-early-warning-system @webkit-commit-queue @szewai
0