[css-transitions] transition-property: all does not apply to custom properties
#10142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anttijk
approved these changes
Feb 15, 2023
Source/WebCore/style/Styleable.cpp
Outdated
Comment on lines
678
to
694
There was a problem hiding this comment.
you should test with RenderStyle::customPropertiesEqual before doing all this work.
There was a problem hiding this comment.
Rules for whether a property will yield to a transition update are complex and encapsulated in updateCSSTransitionsForStyleableAndProperty(). Even though two custom properties could have the same value, some transition properties could yield an update, for instance if the transition-duration changes in flight. I don't think we want to bring up any of the complicity of updateCSSTransitionsForStyleableAndProperty() up to here.
|
EWS run on previous version of this PR (hash f16a492)
|
f16a492 to
5580a54
Compare
|
EWS run on previous version of this PR (hash 5580a54)
|
5580a54 to
2b94908
Compare
|
EWS run on previous version of this PR (hash 2b94908)
|
a38328f to
390ec99
Compare
|
EWS run on previous version of this PR (hash 390ec99)
|
|
EWS run on previous version of this PR (hash a38328f)
|
390ec99 to
faaa468
Compare
|
EWS run on current version of this PR (hash faaa468)
|
… properties https://bugs.webkit.org/show_bug.cgi?id=252312 Reviewed by Antti Koivisto. When setting `transition-property: all`, which also happens to be that property's initial value, we would correctly consider all properties known within WebCore as a CSSPropertyID, but we would fail to consider registered custom properties that could otherwise be interpolated. We now iterate through all custom properties in both the before-change and after-change styles to gather custom properties that can be interpolated (ie. either a SyntaxValue or SyntaxValueList) and run the transition update logic on those. * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/animation/custom-property-transition-property-all-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/animation/custom-property-transition-property-all.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/resources/utils.js: * Source/WebCore/style/Styleable.cpp: (WebCore::Styleable::updateCSSTransitions const): Canonical link: https://commits.webkit.org/260384@main
faaa468 to
fcdce8f
Compare
|
Committed 260384@main (fcdce8f): https://commits.webkit.org/260384@main Reviewed commits have been landed. Closing PR #10142 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fcdce8f
faaa468
🛠 mac🛠 wincairo🧪 ios-wk2🧪 api-mac 8000🧪 gtk-wk2🧪 api-ios🧪 mac-wk1🧪 api-gtk🛠 tv🧪 mac-wk2🧪 mac-AS-debug-wk2🛠 watch🧪 mac-wk2-stress