Allow ImageBufferShareableBitmapBackend to create a ShareableBitmap using PixelFormat::BGRX

heycam · heycam · commit 416fea3fa24b · 2023-01-12T21:52:00.000-08:00
https://bugs.webkit.org/show_bug.cgi?id=250542 rdar://104142373 Reviewed by Simon Fraser. After bug 250100, we can create tile ImageBuffers with PixelFormat::BGRX. We can get in here with UI side compositing enabled and accelerated drawing disabled. * Source/WebKit/WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp: (WebKit::ImageBufferShareableBitmapBackend::create): Canonical link: https://commits.webkit.org/258862@main
diff --git a/Source/WebKit/WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp b/Source/WebKit/WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp
@@ -77,7 +77,7 @@ size_t ImageBufferShareableBitmapBackend::calculateMemoryCost(const Parameters&
 
 std::unique_ptr<ImageBufferShareableBitmapBackend> ImageBufferShareableBitmapBackend::create(const Parameters& parameters, const WebCore::ImageBufferCreationContext&)
 {
-//    ASSERT(parameters.pixelFormat == PixelFormat::BGRA8);
+    ASSERT(parameters.pixelFormat == PixelFormat::BGRA8 || parameters.pixelFormat == PixelFormat::BGRX8);
 
     IntSize backendSize = calculateSafeBackendSize(parameters);
     if (backendSize.isEmpty())

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ size_t ImageBufferShareableBitmapBackend::calculateMemoryCost(const Parameters&`
`77`	`77`
`78`	`78`	`std::unique_ptr<ImageBufferShareableBitmapBackend> ImageBufferShareableBitmapBackend::create(const Parameters& parameters, const WebCore::ImageBufferCreationContext&)`
`79`	`79`	`{`
`80`		`-// ASSERT(parameters.pixelFormat == PixelFormat::BGRA8);`
	`80`	`+ ASSERT(parameters.pixelFormat == PixelFormat::BGRA8 \|\| parameters.pixelFormat == PixelFormat::BGRX8);`
`81`	`81`
`82`	`82`	`IntSize backendSize = calculateSafeBackendSize(parameters);`
`83`	`83`	`if (backendSize.isEmpty())`