imported/w3c/web-platform-tests/feature-policy/reporting/encrypted-media-reporting.https.html is a constant crash

jyavenard · jyavenard · commit b7cf9b027632 · 2023-01-12T21:09:03.000-08:00
https://bugs.webkit.org/show_bug.cgi?id=250534 rdar://104200900 Reviewed by Tim Horton. On iOS AVStreamDataParser::init will manual release the instance. If that pointer was stored in a RetainPtr it would lead to a double-release. * Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.mm: (WebCore::SourceBufferParserAVFObjC::isContentTypeSupported): Canonical link: https://commits.webkit.org/258861@main
diff --git a/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.mm b/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.mm
@@ -209,7 +209,7 @@ AtomString codec() const override
 MediaPlayerEnums::SupportsType SourceBufferParserAVFObjC::isContentTypeSupported(const ContentType& type)
 {
     // Check that AVStreamDataParser is in a functional state.
-    if (!PAL::getAVStreamDataParserClass() || ![adoptNS(PAL::allocAVStreamDataParserInstance()) init])
+    if (!PAL::getAVStreamDataParserClass() || !adoptNS([PAL::allocAVStreamDataParserInstance() init]))
         return MediaPlayerEnums::SupportsType::IsNotSupported;
 
     String extendedType = type.raw();

Original file line number	Diff line number	Diff line change
`@@ -209,7 +209,7 @@ AtomString codec() const override`
`209`	`209`	`MediaPlayerEnums::SupportsType SourceBufferParserAVFObjC::isContentTypeSupported(const ContentType& type)`
`210`	`210`	`{`
`211`	`211`	`// Check that AVStreamDataParser is in a functional state.`
`212`		`- if (!PAL::getAVStreamDataParserClass() \|\| ![adoptNS(PAL::allocAVStreamDataParserInstance()) init])`
	`212`	`+ if (!PAL::getAVStreamDataParserClass() \|\| !adoptNS([PAL::allocAVStreamDataParserInstance() init]))`
`213`	`213`	`return MediaPlayerEnums::SupportsType::IsNotSupported;`
`214`	`214`
`215`	`215`	`String extendedType = type.raw();`