E524 fix(tool): Return Erro BADF error when try to sync a directory by tushar1977 · Pull Request #4572 · WasmEdge/WasmEdge · GitHub
[go: up one dir, main page]
Skip to content

fix(tool): Return Erro BADF error when try to sync a directory #4572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tushar1977 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(tool): Return Erro BADF error when try to sync a directory #4572

tushar1977 wants to merge 2 commits into from
+1 −1

Conversation

@tushar1977
Copy link
@tushar1977 tushar1977 commented Jan 28, 2026

This change aligns WasmEdge’s fd_sync behavior with wasmtime and POSIX by returning __WASI_ERRNO_BADF when fd_sync is invoked on a directory file descriptor, instead of __WASI_ERRNO_NOTCAPABLE.

Issue - #3039

As implemented in wasmtime, the same error is returned whenever a directory file descriptor is encountered. In wasmtime, fd_sync first validates that the file descriptor refers to a regular file:

    async fn fd_sync(&mut self, _memory: &mut GuestMemory<'_>, fd: types::Fd) -> Result<(), Error> {
    self.table().get_file(u32::from(fd))?  <------ get file will invoke and returns Bad file descriptor error
        .file
        .sync()
        .await?;
    Ok(())
}

@tushar1977 tushar1977 requested a review from ibmibmibm as a code owner January 28, 2026 13:52
@github-project-automation github-project-automation bot moved this to Triage-required in WasmEdge Roadmap Jan 28, 2026
@github-actions github-actions bot added the WASI https://github.com/WebAssembly/WASI label Jan 28, 2026
@tushar1977
fix(tool): Return BADF for fd_sync on directory file descriptors
62eaaa8 
Signed-off-by: Tushar Gupta <tushar.197712@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ibmibmibm ibmibmibm Awaiting requested review from ibmibmibm ibmibmibm is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

WASI https://github.com/WebAssembly/WASI

Projects

WasmEdge Roadmap
Status: Triage-required

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tushar1977
0