Update adding-custom-endpoints.md #101
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a clarification for required property and empty values being allowed.
|
Thanks for the PR @kalimah-apps! I don't think this should be called out in an alert of its own, but rather alongside the |
|
I added it as an alert because it was not clear. I assumed required covers the length too. But as long as it is added then it should be fine. |
|
@abdul-alhasany Hello there! It's been a while on this PR -- if you're still interested in seeing this change made, would you be able to update the patch? I agree with Timothy about making this a sub-bullet of the Thank you |
|
@kadamwhite It has been a while and I have removed the branch that created this PR. I am not sure if I can update this patch. I might need to create a new PR with the proposed changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a clarification for required property and empty values being allowed.