Merged
Conversation
Owner
|
hi @balping you can run tests by executing what i see is that your code might not work due to the fact that webpack is serializing options to JSON and back and therefore any callbacks will be lost. try it yourself and add tests to PR if it works, i might be wrong thank you |
Contributor
Author
|
Yes, I can run npm test, but all tests fail, because the lack of the build directory. |
Contributor
Author
|
@Va1 bump |
|
when will this be released? |
|
@Va1 - Hello! Tested these changes locally and they appear to be working well in our app. We’re altering the string replacement depending on the build environment. Anything I can do to help with this c 8000 hange? |
Contributor
Author
|
You could help to figure it out, how to run |
|
I hope to see this landing at some point |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#40
I realised that String.prototype.replace() already has the capability of using callbacks, so only the option validation had to be modified.
I would normally add a test, but I couldn't set up testing. It needs a certain
test/build/build.jsfile that I have no idea how to generate.