8000 chore: upgrade spring-boot-sample to unleash 10 by gastonfournier · Pull Request #304 · Unleash/unleash-client-java · GitHub
[go: up one dir, main page]
Skip to content

chore: upgrade spring-boot-sample to unleash 10 #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

chore: upgrade spring-boot-sample to unleash 10 #304

wants to merge 1 commit into from

Conversation

gastonfournier
Copy link
Contributor
@gastonfournier gastonfournier commented Apr 1, 2025 •
edited
Loading

This is an attempt to verify #288 with SpringBoot: ./gradlew bootRun and accessing http://localhost:8080/all that evaluates all toggles at once.

The result was unsuccessful as I couldn't reproduce the issue.

I also tried locally with a custom header and without synchronousFetchOnInitialisation:

        UnleashConfig config = UnleashConfig.builder().unleashAPI(url).appName(appName)
            //.apiKey(apiKey)
            .customHttpHeader("Authorization", apiKey)
            .instanceId("spring-boot-example")
            .environment("development")
            //.synchronousFetchOnInitialisation(true)
            .fetchTogglesInterval(15).build();

Still the PR is valid to bump the examples

gastonfournier
gastonfournier commented Apr 1, 2025
View reviewed changes
examples/spring-boot-example/src/main/java/io/getunleash/unleash/example/ProxyController.java
@@ -33,7 +33,7 @@ public Map<String, Boolean> getAllToggles() {
}

@GetMapping("/toggle/{toggleName}")
public Boolean getToggle(@PathParam("toggleName") String name) {
public Boolean getToggle(@PathVariable("toggleName") String name) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct way of getting the path variable

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 80.268%. remained the same
when pulling fbde919 on upgrade-spring-boot-example
into fb576bf on main.

@gastonfournier gastonfournier mentioned this pull request Apr 1, 2025
Open
@gastonfournier gastonfournier self-assigned this Apr 1, 2025
@gastonfournier gastonfournier moved this from New to In Progress in Issues and PRs Apr 2, 2025
@gastonfournier
Copy link
Contributor Author

We're not going to upgrade to v10 as we're looking at alternatives to have Yggdrasil inside Java SDK which will likely come with v11

@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriswk chriswk Awaiting requested review from chriswk

@sighphyre sighphyre Awaiting requested review from sighphyre

Assignees

@gastonfournier gastonfournier

Labels
None yet
Projects
Issues and PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gastonfournier @coveralls
0