fix: different interval headers are now sent for metrics/features #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwasniew
reviewed
Mar 3, 2025
| public class OkHttpFeatureFetcher implements FeatureFetcher { | ||
| private final HttpUrl toggleUrl; | ||
| private final OkHttpClient client; | ||
| private final UnleashConfig config; |
There was a problem hiding this comment.
do you need to store the entire config if you only need the interval?
There was a problem hiding this comment.
Storing interval only now
kwasniew
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously same interval was sent to both requests, metrics and features. Now for metrics we are sending metrics interval and for feature fetching, we send refreshInterval.