8000 Changed path() method to getRealPath() by joshuadegier · Pull Request #300 · UniSharp/laravel-filemanager · GitHub
[go: up one dir, main page]

Skip to content

Changed path() method to getRealPath() #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2017
Merged

Changed path() method to getRealPath() #300

merged 1 commit into from
May 18, 2017

Conversation

joshuadegier
Copy link
Contributor

Uploading a regular file using laravel-filemanager causes this error:
Call to undefined method Symfony\Component\HttpFoundation\File\UploadedFile::path()

According to other places inside the code, the correct method should be getRealPath(), after changing both references in the UploadController I was able to upload files without issues. The error only occured when uploading using the "Files" type of the file manager (like a PDF).

Uploading a regular file using laravel-filemanager causes this error:
`Call to undefined method Symfony\Component\HttpFoundation\File\UploadedFile::path()`

According to other places inside the code, the correct method should be `getRealPath()`, after changing both references in the UploadController I was able to upload files without issues. The error only occured when uploading using the "Files" type of the file manager (like a PDF).
@jonjie0317
Copy link

Hi guys. Im facing this error right now. What should I do for this? Thanks

@joshuadegier
Copy link
Contributor Author
joshuadegier commented May 17, 2017

Until this is merged, you can reference my fork, in your composer.json file add these lines:

"repositories": [
    {
        "type": "vcs",
        "url": "https://github.com/PendoNL/laravel-filemanager"
    }
],

And than change the version for file manager to this:

    "unisharp/laravel-filemanager": "dev-master",

Then run composer update, that'll fix it for now with my fork until this is merged.

@jonjie0317
Copy link
jonjie0317 commented May 17, 2017

@PendoNL Hi. Thanks for your solution. One more thing, just wondering what will be the effect or what's the difference if I will do your solution? I mean, hmm because you said "That'll fix it for now." .

Thanks men.

@joshuadegier
Copy link
Contributor Author

As far as I know this is the only solution that works. What I meant was: you may use my fork until this gets merged and we can start using the original package again. Sorry if I confused you with that.

@jonjie0317
Copy link

@PendoNL Ohw, that's great. Thank you . I'll try it now.

@jonjie0317
Copy link

@PendoNL What did you do, to make it work men?

@joshuadegier
Copy link
Contributor Author

See the details on the PR, just changed 2 lines of code:
https://github.com/UniSharp/laravel-filemanager/pull/300/files

@jonjie0317
Copy link

@PendoNL Wow! you're so great men 👍

@streamtw
Copy link
Member

Thank you so much @PendoNL .

@streamtw streamtw merged commit 4efe705 into UniSharp:master May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0