LazyEncodedString everywhere #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Not complete! * This compiles the interop and wrapper libraries only, no impacted libs are updated yet.
* Includes additional testing
* Apparently the JIT is assuming a 32 bit relocation as the default.
- See llvm/llvm-project#65641
* This adds support for JIT builder and, in particular, TargetMachineBuilder so that the CodeModel is explicit in children
* Static usings are now explicit everywhere they are needed.
- This removes static usings from the global usings.
* Converted name of static class for LLVM-C interop `Error` for consistency
* Added marshaling form of `LLVMCreateStringError()`
* Added `LLVMErrorRef.CreateForNativeOut()`
- Eliminates need for annoying IDisposable warning suppression in many cases.
- This support out/return of native handle for reverse P/Invoke scenarios.
* Added setting the triple to the module transform for Kaleidoscope
- Ensures the triple is set and matches the JIT.
* Added `MarshalGCHandle.TryGet<>()` to support more intuitive acquisition of a managed context in native callbacks.
* Moved static factory for `ErrorInfo` to a constructor.
- Static factory was used for out/return to native but that causes a lot of suppression of warnings for dispose so isn't used. Instead, most APIs will use the static methods on LLVMErrorRef to report any errors. If the callback includes calling through a delegate, then it might use the constructor to build the resulting `ErrorInfo` to pass to native code.
* Since native API surface changed to support this build the version bump is needed
* Added LibLLVMAttributeAllowedOn_All to make testing easier
* Changed signature of LibLLVMGetAttributeInfo to use an out param as the result instead of a raw pointer
- Wrapper layout is identical to the interop form so a simple cast through a pointer is all that is needed to "project"
* Doc comment updates/fixes
* Test file was removed locally and missed
- commit only included staged files so this edit and replace got in the way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support use of LazyEncodedString everywhere to enhance performance overhead with pre-encoded strings etc.
Consumers of this library (and samples) should use the
u8suffix on all string literals to allow the compiler to perform encoding of the strings at compile time to reduce the overhead of conversion at runtime.