Color blind friendly mode patch #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added color-blind-friendly command-line flag. Optimized looping through plugin_chain to set user-defined output arguments.
Added color-blind-friendly, "cbf" argument (user-defined command-line option) to base-level output class to be used by colorout and htmlout output modules.
Activate color blind friendly mode in colorout output module. Use ANSI color yellow (darker yellow) in place of red. Different shades of green/yellow/blue are used which helps better differentiate between them. The base-level Output() class' setup() function is called within the _premodule() function of the plugin using this output module, before capture starts or files are read.
Activate color blind friendly mode in htmlout output module. Use HTML colors gold (darker yellow) in place of red, and sea green (lighter green) in place of green. Keep the HTML color blue the same. These different shades of green/yellow/blue are used to help better differentiate between them. The base-level Output() class' setup() function is called within the _premodule() function of the plugin using this output module, before capture starts or files are read.
Removed TODO comment regarding making the colors configurable to be color blind friendly.
Updated argument parsing syntax for 'cbf' and 'acc' command-line options to conform with standard form used, '-' for single char options, '--' for multiple char options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added color blind friendly mode, which will currently be used by the colorout and htmlout output modules. Uses yellow/gold in place of red and different shades of green/yellow/blue to help users with protanopia, deuteranopia, or tritanopia better differentiate between them, as well as for users interested in alternate color schemes.