Production polish chapter 2 #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 17, 2022
… from objectives; .csv formatting consistency
This was
linked to
issues
Dec 19, 2022
Closed
❌ Deploy Preview for mellifluous-pie-f3e391 failed.
|
joelostblom
approved these changes
Dec 21, 2022
Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com>
Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com>
Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com>
trevorcampbell
added a commit
that referenced
this pull request
Dec 21, 2022
* moved old stuff into the unused folder; may delete later * added ibis framework to dockerfile * empty commit to dockerfile to trigger rebuild * update build_html.sh script with new docker image * added chmod u+x to build env update script * Production polish chapter 1 (#48) * empty commit for WIP PR * ignore vim swap files * python and pandas fix; code tags around df[] * fix 'Chapter X' typesetting * an python fix * fix broken url to data in this repo * fixed capitalization in pandas team in refs.bib * more bugfix in pandas dev team refs.ib * pd alias; removing print stmts in initial naming part; fixed naming syntax * single vs double quotes; property -> operation; df[] to just [] * fixed chapter typesetting to be even better * added note about wrong fig 1.2 * added remarks about square brackets and dots * dataframe -> data frame * documented all missing figures * height of bars to lengths of bars; fixed exercises title and url * added explanation of ranges * polish and simplification of altair intro; fixed multi-line expression text * fixed putting it together code block; removed docstring help * editing learning objs for overhaul of loc/[]/iloc in ch1 * get rid of prepended . on function/method names. some minor wording polish * fixed loc and [] in chapter 1 * putting all together new loc and [] * altair name typesetting consistency * general -> powerful in notebox Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com> * remove unnecessary second multiline example Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com> * build html executable * switched [] to be for rows or cols, and loc[] to be for both * minor wording polish Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com> * minor spacing fix Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com> * minor wording polish Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com> * minor spacing fix Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com> Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com> * Production polish chapter 2 (#49) * empty commit for WIP PR * hide ignore warnings cell; import pandas move down; remove read_table from objectives; .csv formatting consistency * fixed canadian language data with metainfo * fixed tsv/no cols data in ch2 * working on polishing reading * polished ch2 up to db section * commented out web scraping and api for first round; issue opened * commented out learning objs for scraping/api * built_html executable * done new ibis database section * Fixed learning objectives sqlalch -> ibis; minor sqlalch bugfixes * ibis "modern" Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com> * nicer formatting of readcsv with args Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com> * minor polish on wording * fix header in skiprows example * nicer formatting on ibis connect args Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com> * Removed warnings filter--unneeded * index false in to_csv Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge #46 before this one.#46 has been merged, so this is safe now.Done this now.
read_table#36