8000 Added new tsconfig options by lhecker · Pull Request #1133 · TypeStrong/atom-typescript · GitHub
[go: up one dir, main page]

Skip to content

Added new tsconfig options #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2016
Merged

Added new tsconfig options #1133

merged 2 commits into from
Nov 15, 2016

Conversation

lhecker
Copy link
Contributor
@lhecker lhecker commented Nov 15, 2016

[x] All compiled assets are included (atom packages are git tags and hence the built files need to be a part of the source control)

This adds:

  • the es2016, es2017 and esnext targets
  • alwaysStrict option
  • jsxFactory option

Furthermore:
I wasn't so sure what typescriptEnumMap does when a value is not defined:
"latest" was only defined in typescriptEnumMap but not in the validator. "es2015" on the other hand did exist in validator but not in the map.
So I removed "latest" entirely and replaced it with the now official esnext mode (which is aliased to latest - thus backwards compatible).

I also took the liberty to sort the interface and validator keys in c6b7d00 - there are no other changes in that commit.
3f40b96 on the other hand introduces the actual changes above.

B4E9
This adds
- the es2016, es2017 and esnext targets
- alwaysStrict option
- jsxFactory option
@guncha
Copy link
Contributor
guncha commented Nov 15, 2016

Thanks!

Yeah, looks like latest is not a valid target value, while it's used internally by Typescript.

@guncha guncha merged commit 3cc3d7f into TypeStrong:master Nov 15, 2016
@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0