-
-
Notifications
You must be signed in to change notification settings - Fork 181
fix: ensure parent pointers are correctly set for transformed nodes #1613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ChouUn
wants to merge
1
commit into
TypeScriptToLua:master
Choose a base branch
from
ChouUn:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `setParent` function was applied to `updatedBlock` instead of `result`, which could lead to incorrect parent pointers in the final transformed AST. This fix ensures that parent pointers are correctly set for the final transformed node (`result`) and its subtree, maintaining the integrity of the AST during transformations.
Perryvw
reviewed
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The before and after of this code looks like they should behave identically to me. Did this actually solve the problem you were having? Can you give an example of a transformer that breaks here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working on writing plugins recently and encountered some issues, so I've been reading source codes of TSTL to learn more. Thus, I noticed some parts that seem a bit unreasonable.
Previously, the
setParentfunction was applied toupdatedBlockinstead ofresult, which may lead to incorrect parent pointers in the final transformed AST. This fix ensures that parent pointers are correctly set for the final transformed noderesultand its subtree, maintaining the integrity of the AST during transformations.As I am just beginning to delve into the source code, my understanding of it may not be entirely accurate. If this is an erroneous fix, please correct me and do not hesitate to explain the rationale behind your coding approach.