8000 Unit test addition complete and fixied bug found in source code by anshulsahni · Pull Request #1 · TryReact/password-input · GitHub
[go: up one dir, main page]
Skip to content

Unit test addition complete and fixied bug found in source code #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 29, 2017
Merged

Unit test addition complete and fixied bug found in source code #1

merged 6 commits into from
Mar 29, 2017

Conversation

anshulsahni
Copy link
Contributor
@anshulsahni anshulsahni commented Mar 29, 2017 •
edited
Loading

This PR contains

  1. Addition of more tests
  2. fixing of a cruicial bug in applyRules - .isMax() and .isMin() method of password-validator api were misspelt as max() and min()
  3. File Password.jsx changed to PasswordInput and also changing of name inside the tests

@anshulsahni anshulsahni self-assigned this Mar 29, 2017
@anshulsahni anshulsahni merged commit 99f5c9b into master Mar 29, 2017
@anshulsahni anshulsahni deleted the more-unit-tests branch March 29, 2017 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@anshulsahni anshulsahni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@anshulsahni
0