10BC0 Semantic update to userAddress auth-context state value by johngribbin · Pull Request #282 · TruSat/trusat-frontend · GitHub
[go: up one dir, main page]
Skip to content

Semantic update to userAddress auth-context state value #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
johngribbin wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Semantic update to userAddress auth-context state value #282

johngribbin wants to merge 2 commits into from

Conversation

@johngribbin
Copy link
Collaborator
@johngribbin johngribbin commented Apr 1, 2020
  • Up until now the default value for user address has been the string value none,
  • This is used by many components to assess if the user was logged in or not.
  • With this change, the default is now undefined (type undefined) and the components that utilize the userAddress value (conditional rendering etc) have all been updated to recognize this change
  • This change not only makes the code more legible but I believe it is just a better practice

@johngribbin
Copy link
Collaborator Author
johngribbin commented Apr 1, 2020

@Kmoneal Does changing the default state of userAddress from "none" to undefined cause any breaking changes on the backend? If not, i'd like to merge this change. Not a huge priority though, so if it does cause any hassle on backend - we can delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johngribbin
0