fix: replace unsafe while(*it) loops#574
Closed
bobtista wants to merge 1 commit intoTheSuperHackers:mainfrom
Closed
fix: replace unsafe while(*it) loops#574bobtista wants to merge 1 commit intoTheSuperHackers:mainfrom
bobtista wants to merge 1 commit intoTheSuperHackers:mainfrom
Conversation
xezon
reviewed
Apr 2, 2025
|
|
||
| while( *it ) | ||
| ContainedItemsList::const_iterator end = items->end(); | ||
| while( it != end ) |
There was a problem hiding this comment.
Put space between loop and variable like at the other places.
| @@ -347,8 +347,8 @@ UpdateSleepTime MobNexusContain::update() | |||
| { | |||
| ContainedItemsList::const_iterator it; | |||
| it = items->begin(); | |||
There was a problem hiding this comment.
While at it, perhaps make the declaration and assignment a single line? Looks a bit unholy right now.
|
All of these are included in the Fixes needed for Debug to work properly without asserting in the STL library. But nice work on looking into things! The more help the merrier. :) |
Author
|
Already covered in #563 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #302
Minimal changes for simple diff, we could refactor later to use for loops like it's done in other places.