8000 New tests by imrogerjiang · Pull Request #74 · TheOdinProject/javascript-exercises · GitHub
[go: up one dir, main page]
Skip to content

New tests #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 9, 2020
Merged

New tests #74

merged 3 commits into from
May 9, 2020

Conversation

imrogerjiang
Copy link
Contributor
@imrogerjiang imrogerjiang commented May 8, 2020 •
edited
Loading

Added the follow tests for edge cases.

  • removeFromArray: tests whether elements are removed from the array even though they are of different types. e.g. 1 should not be removed by "1"
  • reverseString: tests whether the function works for blank strings.
  • repeatString: tests whether the function works for blank strings.

This is my first time contributing to a public project so please let me know if I did something wrong.

@I3uckwheat I3uckwheat merged commit 888383a into TheOdinProject:master May 9, 2020
willgodev pushed a commit to willgodev/javascript-exercises that referenced this pull request Dec 21, 2020
@I3uckwheat
Merge pull request TheOdinProject#74 from imrogerjiang/new-tests
69ac960
Oussama5379 added a commit to Oussama5379/javascript-exercises that referenced this pull request Feb 1, 2025
@Oussama5379
Merge pull request TheOdinProject#74 from imrogerjiang/new-tests
7b2f4aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imrogerjiang @I3uckwheat
0