-
Notifications
You must be signed in to change notification settings - Fork 38.8k
Github: Refactor issue forms to YAML #491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏
value: | | ||
1. Step 1 | ||
2. Step 2 | ||
3. Step 3 | ||
|
||
E.g.: | ||
1. Log in | ||
2. Visit a lesson page | ||
3. Click the complete button | ||
4. The complete button does not update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make this a placeholder instead (same for the other ones in this file and the feature request one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what I tried first with the checkboxes list. The list in the placeholder renders in a single line, which looks odd. I'll check what we can do about that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The website repo feature request form just does what you did but with placeholder
instead of value
. It initially renders with new lines but when you focus the textarea, it goes onto one line instead. Might not be much we can do about that but I'm not really concerned about it appearing on one line with a focused textarea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit disappointing, but oh well...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks A09A for doing this!
Because
Makes opening issues faster and easier.
This PR
Refactors the two issue forms to the new YAML issue form template.
Issue
Closes #487
Additional Information
Open to further refinements
Pull Request Requirements
location of change: brief description of change
format, e.g.01_helloWorld: Update test cases
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section/solutions
folder