Project Root: Add minimum npm & node version requirements #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will prevent any old node or npm version from installing any packages. With this, npm will throw an error and exit immediately. This is to prevent the accidental use of unsupported versions which might cause some issues that are hard to pin-point.
wise-king-sullyman
approved these changes
Jun 11, 2024
Oussama5379
added a commit
to Oussama5379/javascript-exercises
that referenced
this pull request
Feb 1, 2025
Project Root: Add minimum npm & node version requirements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will prevent any old node or npm version from installing any packages. With this, npm will throw an error and exit immediately. This is to prevent the accidental use of unsupported versions which might cause some issues that are hard to pin-point.
Because
A person on Discord was getting some syntax errors when running Jest after installing the packages. It took us a while to figure out that the person was using a really old version of node. The additions in this PR will prevent something like this from happening. If someone tries to run the
npm installcommand with an outdated node/npm version inside the repo, then npm will exit with an error, informing the user their version is too low and what the minimum required version is.This PR
package.jsonfile with the minimum supported node and npm versionspackage-lock.json.npmrcconfig file with an option that failsnpm installwith an error and exits (without this, npm only shows warnings)Additional Information
Pull Request Requirements
location of change: brief description of changeformat, e.g.01_helloWorld: Update test casesBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection/solutionsfolder