8000 Changed number to integer in sumAll by saadsultan7 · Pull Request #477 · TheOdinProject/javascript-exercises · GitHub
[go: up one dir, main page]
Skip to content

Changed number to integer in sumAll #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2024
Merged

Changed number to integer in sumAll #477

merged 1 commit into from
Jun 1, 2024

Conversation

saadsultan7
Copy link
Contributor
@saadsultan7 saadsultan7 commented Jun 1, 2024 •
edited
Loading

Because

The problem statement says:
"Implement a function that takes 2 positive integers and returns the sum of every number between (and including) them"
It should say:
"Implement a function that takes 2 positive integers and returns the sum of every integer between (and including) them"

This PR

In the sumAll folder the statement problem from number to integer is fixed

Issue

Closes #476

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. 01_helloWorld: Update test cases
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If this PR includes any changes that affect the solution of an exercise, I've also updated the solution in the /solutions folder

MaoShizhong
MaoShizhong approved these changes Jun 1, 2024
View reviewed changes
Copy link
Contributor
@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🚀

@MaoShizhong MaoShizhong merged commit 2154dce into TheOdinProject:main Jun 1, 2024
Oussama5379 added a commit to Oussama5379/javascript-exercises that referenced this pull request Feb 1, 2025
@Oussama5379
Changed number to integer in sumAll (TheOdinProject#477)
634114c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaoShizhong MaoShizhong MaoShizhong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change number to integer in sumAll problem statement
2 participants
@saadsultan7 @MaoShizhong
0