8000 Change styling of notes for avoiding PRs and error messages by JoshDevHub · Pull Request #465 · TheOdinProject/javascript-exercises · GitHub
[go: up one dir, main page]
Skip to content

Change styling of notes for avoiding PRs and error messages #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2024
Merged

Change styling of notes for avoiding PRs and error messages #465

merged 1 commit into from
May 4, 2024

Conversation

JoshDevHub
Copy link
Contributor

Because

The notes for avoiding solution PRs to the repo and ignoring NPM ERR statements could be better differentiated from the other setup instructions.

This PR

  • Place PR note in an Important note box
  • Place NPM ERR statement note in a note box

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. 01_helloWorld: Update test cases
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If this PR includes any changes that affect the solution of an exercise, I've also updated the solution in the /solutions folder

@JoshDevHub JoshDevHub requested a review from MaoShizhong May 4, 2024 20:09
@JoshDevHub JoshDevHub merged commit 097a736 into TheOdinProject:main May 4, 2024
@JoshDevHub JoshDevHub deleted the change_style_of_notes branch May 4, 2024 20:12
Oussama5379 added a commit to Oussama5379/javascript-exercises that referenced this pull request Feb 1, 2025
@Oussama5379
Merge pull request TheOdinProject#465 from JoshDevHub/change_style_of…
31371ac 
…_notes

Change styling of notes for avoiding PRs and error messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaoShizhong MaoShizhong MaoShizhong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshDevHub @MaoShizhong
0