Fix palindromes false positive test #227

Mclilzee · 2022-02-08T19:57:03Z

As all palindromes have the exact same first and last letter, people only had to test for first and last letter equallity, and the only test where it should return false, it has the first and last letters being different. to pass the whole test people only had to test for first and last letter weither they are equal or not, which make mistakes like this pass the test :

const palindromes = function (input) {
  let str = input.replace(/[^0-9a-z]/gi, "").toLowerCase();
  for (var i in str) {
    if (str[i] != str[str.length-1-i]) {
      return false;
    }
    return true;
  }
};

this mistake happens to a lot of people, where they return true inside rather than outside the loop. I myself did this mistake many times.

My change will make sure that the first and last letter of a none-palindrome sentence the same, which returns true if people only tested first and last letter. passing the tests now require people to do the palindrome test properly.

OoChip

look ok

OoChip · 2022-02-11T21:53:36Z

09_palindromes/palindromes.spec.js

@@ -17,6 +17,6 @@ describe('palindromes', () => {
    expect(palindromes('Animal loots foliated detail of stool lamina.')).toBe(true);
  });
  test.skip('doesn\'t just always return true', () => {
-    expect(palindromes('ZZZZ car, a man, a maraca.')).toBe(false);


xandora

Good catch, change looks good to me.

Fix palindromes false positive test

1acdfcc

OoChip approved these changes Feb 11, 2022

View reviewed changes

xandora approved these changes Feb 12, 2022

View reviewed changes

xandora merged commit 2f9f431 into TheOdinProject:main Feb 12, 2022

d2038 pushed a commit to d2038/javascript-exercises that referenced this pull request May 22, 2024

Merge pull request TheOdinProject#227 from Mclilzee/main

e6c755b

Oussama5379 added a commit to Oussama5379/javascript-exercises that referenced this pull request Feb 1, 2025

Merge pull request TheOdinProject#227 from Mclilzee/main

dedaba9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix palindromes false positive test #227

Fix palindromes false positive test #227

Fix palindromes false positive test #227

Fix palindromes false positive test #227

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment