8000 Moved the formatter script to the formatter action path by tjgurwara99 · Pull Request #14 · TheAlgorithms/scripts · GitHub
[go: up one dir, main page]
Skip to content

Moved the formatter script to the formatter action path #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from 10000
Jan 20, 2023
Merged

Moved the formatter script to the formatter action path #14

merged 2 commits into from
Jan 20, 2023

Conversation

tjgurwara99
Copy link
Member
@tjgurwara99 tjgurwara99 commented Jan 20, 2023 •
edited
Loading

Fix is working - https://github.com/tjgurwara99/scripts/actions/runs/3967396047/jobs/6799328093

I didn't see that you'd moved the filename_formatter.sh out of the action path.

Panquesito7
Panquesito7 previously approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member
@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Thanks! 🚀
To add backward compatibility, we should keep it. Various repositories still use it from the root directory.

@Panquesito7 Panquesito7 added the enhancement New feature or request label Jan 20, 2023
@Panquesito7
Add filename formatter in root
d3ad99a 
For backward compatibility.
@Panquesito7 Panquesito7 merged commit a3d6183 into main Jan 20, 2023
@Panquesito7 Panquesito7 deleted the tjgurwara99-patch-1 branch January 20, 2023 20:02
@Panquesito7
Copy link
Member

Forgot to mention: do we need to do this for the directory workflow as well?

@tjgurwara99
Copy link
Member Author

Yeah that one also needs to be changed 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Panquesito7 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjgurwara99 @Panquesito7
0