8000 Minor style fix: Heap Implementation by sozelfist · Pull Request #237 · TheAlgorithms/TypeScript · GitHub
[go: up one dir, main page]
Skip to content

Minor style fix: Heap Implementation #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2024
Merged

Minor style fix: Heap Implementation #237

merged 1 commit into from
Apr 12, 2024

Conversation

sozelfist
Copy link
Contributor

Changes made

  • Improved comments for clarity and correctness.
  • Used default parameter values where applicable for better readability.
  • Consistently used void return type for functions without a return value.
  • Ensured consistent use of semicolons for statement termination.
  • Made minor adjustments to ensure consistency in naming and coding style.

@sozelfist
ref: update Heap implementation
b5bb71c 
- Improved comments for clarity and correctness.
- Used default parameter values where applicable for better readability.
- Consistently used `void` return type for functions without a return value.
- Ensured consistent use of semicolons for statement termination.
- Made minor adjustments to ensure consistency in naming and
8000
 coding style.
appgurueu
appgurueu approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor
@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, though I would probably call this "minor style fixes" or similar rather than "refactoring": The structure of the code is left unchanged overall, this PR just fixes typos, adds trivial type annotations, uses default parameters, etc.

@sozelfist sozelfist changed the title Refactor Heap Implementation Minor style fix: Heap Implementation Apr 10, 2024
@raklaptudirm raklaptudirm merged commit e1f635a into TheAlgorithms:master Apr 12, 2024
@sozelfist sozelfist deleted the ref/ds/heap branch April 12, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sozelfist @appgurueu @raklaptudirm
0