8000 test: fix `square_root.test.ts` by vil02 · Pull Request #229 · TheAlgorithms/TypeScript · GitHub
[go: up one dir, main page]
Skip to content

test: fix square_root.test.ts #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2024
Merged

test: fix square_root.test.ts #229

merged 1 commit into from
Feb 14, 2024

Conversation

vil02
Copy link
Member
@vil02 vil02 commented Feb 11, 2024 •
edited
Loading

There is something strange with square_root.test.ts. This PR fixes that.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4f6cd6c) 96.32% compared to head (b65de75) 96.71%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
+ Coverage   96.32%   96.71%   +0.38%     
==========================================
  Files          97       97              
  Lines        1797     1797              
  Branches      347      347              
==========================================
+ Hits         1731     1738       +7     
+ Misses         66       59       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02 vil02 marked this pull request as ready for review February 11, 2024 10:53
appgurueu
appgurueu approved these changes Feb 11, 2024
View reviewed changes
Copy link
Contributor
@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Yep, this fixes the tests, hence increasing the coverage. Before, they just created closures that were never called. We should probably introduce a linter to catch mistakes such as this one.

@appgurueu appgurueu changed the title test: cleanup square_root.test.ts test: fix square_root.test.ts Feb 11, 2024
@vil02 vil02 mentioned this pull request Feb 11, 2024
Merged
@raklaptudirm raklaptudirm merged commit 24cbb3b into TheAlgorithms:master Feb 14, 2024
@vil02 vil02 deleted the cleanup_square_root_test branch February 14, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vil02 @codecov-commenter @appgurueu @raklaptudirm
0