8000 Implemented M Coloring Problem by vedas-dixit · Pull Request #1562 · TheAlgorithms/JavaScript · GitHub
[go: up one dir, main page]
Skip to content

Implemented M Coloring Problem #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 24, 2023
Merged

Implemented M Coloring Problem #1562

merged 6 commits into from
Oct 24, 2023

Conversation

vedas-dixit
Copy link
Contributor
@vedas-dixit vedas-dixit commented Oct 22, 2023 •
edited
Loading

Open in Gitpod know more

Describe your change:

  • [x ] Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • [x ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x ] All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

appgurueu
appgurueu requested changes Oct 22, 2023
View reviewed changes
Copy link
Collaborator
@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also seems to me that an adjacency list representation would be more suitable?

@vedas-dixit
Copy link
Contributor Author

Thank you @appgurueu for the detailed review. I appreciate the feedback and suggestions. I'll work on implementing the changes you recommended:

I'll consider switching to an adjacency list representation for better efficiency.
I'll refine the comments, utilize proper JS Doc comments, and ensure that explanations are placed next to the relevant code.
I'll revisit the class-based approach and try to refactor it to a functional one as you suggested.
I'll push these changes soon. Thanks again for the insights!

@vedas-dixit
Implemented M Coloring Problem
f945eb1
@vedas-dixit
Switch to a functional approach instead of class-based.
95cab08 
Use proper JSDoc comments.
Refine the comments and remove redundancies.
@vedas-dixit vedas-dixit force-pushed the m-coloring-backtracking branch from a6edadf to 95cab08 Compare October 23, 2023 05:13
@vedas-dixit vedas-dixit reopened this Oct 23, 2023
@vedas-dixit vedas-dixit requested a review from appgurueu October 23, 2023 05:44
@raklaptudirm raklaptudirm merged commit fb134b1 into TheAlgorithms:master Oct 24, 2023
@vedas-dixit vedas-dixit deleted the m-coloring-backtracking branch October 26, 2023 06:26
@vedas-dixit vedas-dixit restored the m-coloring-backtracking branch October 26, 2023 06:26
@vedas-dixit vedas-dixit deleted the m-coloring-backtracking branch October 26, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vedas-dixit @appgurueu @raklaptudirm
0