8000 Update BinaryCountSetBits.js by imrahulkb · Pull Request #1532 · TheAlgorithms/JavaScript · GitHub
[go: up one dir, main page]
Skip to content

Update BinaryCountSetBits.js #1532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 14, 2023
Merged

Update BinaryCountSetBits.js #1532

merged 2 commits into from
Oct 14, 2023

Conversation

imrahulkb
Copy link
Contributor

Open in Gitpod know more

Describe your change:

Change in the algorithm.
Original algorithm used to convert the number in binary string and later split at the place where there is character 1.
The split substring are stored in an array and array.length - 1 is returned.
In the updated code the Brian Kernighan's Algorithm is used which has much lower time complexity (i.e. O(number of set bits)).

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@imrahulkb
Copy link
Contributor Author

Sure, thank you for the suggestion

@raklaptudirm raklaptudirm merged commit 46362e3 into TheAlgorithms:master Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imrahulkb @appgurueu @raklaptudirm
0