fix: uv package issue and we now are able to install tradingagents by uv #265
Conversation
Summary of ChangesHello @Jasonsey, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical issue that previously prevented the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request introduces changes to the pyproject.toml file to incorporate uv_build for building the tradingagents package. This involves adding a build-system section specifying uv_build as the build backend and a tool.uv.build-backend section to define the module name and root. I have identified a critical issue where the setup.py file is still present, which conflicts with the new uv_build configuration. This needs to be resolved to ensure a smooth transition to the new build system.
| [build-system] | ||
| requires = ["uv_build>=0.8.5, <0.9.0"] | ||
| build-backend = "uv_build" | ||
|
|
||
| [tool.uv.build-backend] | ||
| module-name = "tradingagents" | ||
| module-root = "" |
There was a problem hiding this comment.
The addition of the build-system and tool.uv.build-backend sections in pyproject.toml indicates a transition to using uv_build. However, the setup.py file is still present in the repository. This can lead to conflicts and confusion during the build process. It's critical to remove setup.py to ensure that uv_build is the sole build system in use.
Consider removing setup.py and any related configurations to avoid potential issues.
fix uv package issue and we now are able to install tradingagents by uv