Adding force encoding to fix the issue in windows. #228
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @Bing4Ever, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a file encoding issue that specifically affects Windows environments. By explicitly specifying UTF-8 encoding when writing to files, it ensures consistent behavior across different operating systems, preventing errors related to character encoding differences.
Highlights
- Windows Compatibility: Explicitly sets "encoding="utf-8"" when opening files for writing log messages and report sections, resolving issues where Windows systems might default to a different encoding, leading to errors.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a file encoding issue on Windows by explicitly setting encoding='utf-8' when opening files for logging and report generation. The changes are correct and necessary for cross-platform compatibility. I've added one suggestion to refactor duplicated code for writing to the log file, which would improve maintainability. While the changes in this PR are good, I'd recommend a quick search for other open() calls in the project that might be missing the encoding parameter to prevent similar issues elsewhere.
| with open(log_file, "a", encoding="utf-8") as f: | ||
| f.write(f"{timestamp} [{message_type}] {content}\n") |
There was a problem hiding this comment.
While adding the encoding is correct, I noticed that the logic for opening and writing to the log file is duplicated here and in save_tool_call_decorator (lines 778-779). Since you're modifying this code, it would be a good opportunity to refactor this into a single helper function to avoid code duplication and improve maintainability. For example:
def _append_to_log(log_line: str):
with open(log_file, "a", encoding="utf-8") as f:
f.write(log_line)This helper could then be called from both save_message_decorator and save_tool_call_decorator.
|
I work off a phone
…On Thu, Sep 18, 2025, 2:42 AM gemini-code-assist[bot] < ***@***.***> wrote:
***@***.***[bot]* commented on this pull request.
Code Review
This pull request correctly addresses a file encoding issue on Windows by
explicitly setting encoding='utf-8' when opening files for logging and
report generation. The changes are correct and necessary for cross-platform
compatibility. I've added one suggestion to refactor duplicated code for
writing to the log file, which would improve maintainability. While the
changes in this PR are good, I'd recommend a quick search for other open()
calls in the project that might be missing the encoding parameter to
prevent similar issues elsewhere.
------------------------------
In cli/main.py
<#228 (comment)>
:
> + with open(log_file, "a", encoding="utf-8") as f:
f.write(f"{timestamp} [{message_type}] {content}\n")
[image: medium]
<https://camo.githubusercontent.com/a33c7ba47779a2aabda978d90fc2665dd949d88da87f5ff554e65308de059f02/68747470733a2f2f7777772e677374617469632e636f6d2f636f64657265766965776167656e742f6d656469756d2d7072696f726974792e737667>
While adding the encoding is correct, I noticed that the logic for opening
and writing to the log file is duplicated here and in
save_tool_call_decorator (lines 778-779). Since you're modifying this
code, it would be a good opportunity to refactor this into a single helper
function to avoid code duplication and improve maintainability. For example:
def _append_to_log(log_line: str):
with open(log_file, "a", encoding="utf-8") as f:
f.write(log_line)
This helper could then be called from both save_message_decorator and
save_tool_call_decorator.
—
Reply to this email directly, view it on GitHub
<#228 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BSY6XJJBHAFP2RXP6WJKZAD3TJO7RAVCNFSM6AAAAACG2XU3HCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTEMZXHA3DQOJVGY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Set |
There will be an error as following when running in the Windows
The reason of this is windows don't force the encoding as utf-8 while it is default in MacOS/linux.
force the encoding will fix the issue or you can mention it in the Readme to set the default uncoding as utf-8 via the commandline.