Closed
Conversation
…iption(), summarize()
Contributor
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThis PR adds embedding functionality to the TanStack AI framework. It introduces a base embedding adapter abstraction, implements a Gemini-specific embedding adapter, creates embed and embedMany activities with event emission, integrates telemetry across multiple activities, extends the event system with embedding-related events, and adds OpenTelemetry tracing utilities for observability. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Activity as embed Activity
participant Adapter as EmbeddingAdapter
participant Tracer
participant EventClient
Client->>Activity: embed({ adapter, value, modelOptions, telemetry })
Activity->>Activity: generateRequestId()
Activity->>EventClient: emit 'embed:request:started'
Activity->>Tracer: getTracer(telemetry.tracer)
Activity->>Activity: recordSpan({ tracer, name, attributes, fn })
Activity->>Adapter: embed({ value, modelOptions })
Adapter-->>Activity: EmbedResult { id, model, embedding, usage }
Activity->>EventClient: emit 'embed:request:completed'
Activity->>EventClient: emit 'embed:usage' (if usage exists)
Activity-->>Client: EmbedResult
sequenceDiagram
participant Activity as Activity (chat/image/speech/etc)
participant Tracer
participant Span
participant Adapter
participant EventClient
Activity->>Activity: recordSpan({ tracer, name, attributes, fn })
Tracer->>Span: startSpan(name, attributes)
Activity->>EventClient: emit 'request:started' with telemetry
Span->>Adapter: execute adapter call
Adapter-->>Span: result with usage/response data
Activity->>Span: recordAttribute(span, 'gen_ai.response.id', id)
Activity->>Span: recordAttribute(span, input/output tokens)
Activity->>EventClient: emit 'request:completed' with telemetry
Activity->>EventClient: emit 'usage' with telemetry (if applicable)
Span-->>Activity: end span
Activity-->>Client: result
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx affected --targets=test:sherif,test:knip,tes... |
❌ Failed | 3m 8s | View ↗ |
nx run-many --targets=build --exclude=examples/** |
✅ Succeeded | 1m 20s | View ↗ |
☁️ Nx Cloud last updated this comment at 2026-02-13 18:13:32 UTC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Added
embed/embedManyactivity and Gemini embedding adapter✅ Checklist
pnpm run test:pr.🚀 Release Impact
Summary by CodeRabbit
New Features
Chores