Do not throw error when no reviewer found

TailorDev · Feb 21, 2017 · 915239d · 915239d
1 parent 7cd57ac
commit 915239d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/tasks/findReviewers.js b/tasks/findReviewers.js
@@ -179,13 +179,9 @@ exports.configure = config => async (repositoryId, number, author, logger) => {
     .then(take(repository.max_reviewers))
     // create review request
     .then((selected) => {
-      if (selected.length === 0) {
-        throw createHttpError(422, 'aborted', 'no reviewers found');
-      }
-
       logSelectReviewers(logger, repository, number, selected);
 
-      if (config.createReviewRequest === false) {
+      if (selected.length === 0 || config.
8000
createReviewRequest === false) {
         return Promise.resolve();
       }
 

diff --git a/test/tasks/findReviewers.js b/test/tasks/findReviewers.js
@@ -46,7 +46,7 @@ describe('tasks/findReviewers', () => {
       expect(reviewers).to.deep.equal({});
     });
 
-    it('should does not return any reviewer when no collaborators', () => {
+    it('should not return any reviewer when no collaborators', () => {
       const reviewers = getPotentialReviewers({ boo: 23, baz: 1 }, {});
 
       expect(reviewers).to.deep.equal({});