[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix an abstract model violation msg #2559

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

fix an abstract model violation msg #2559

wants to merge 3 commits into from

Conversation

sydb
Copy link
Member
@sydb sydb commented May 19, 2024

This is intended to address #2497. As a side effect, it simplifies the Schematron, too.

  • Updated Schematron as per issue
  • Added a test to detest.xml
  • Updated expected results to match new test file

@sydb
Address #2497:
331cb41 
 * Updated Schematron as per issue
 * Added a test to detest.xml
 * Updated expected results to match new test file
@sydb sydb added this to the Guidelines 4.8.0 milestone May 19, 2024
torstenroeder
torstenroeder reviewed Oct 4, 2024
View reviewed changes
Copy link
Contributor
@torstenroeder torstenroeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look right to me. What about the checks? Do they need to pass before approval?

@ebeshero
Copy link
Member
ebeshero commented Oct 4, 2024

@torstenroeder The tests need to pass. The branch seriously needs to be updated from dev, and then we can test it again.

@sydb
Copy link
Member Author
sydb commented Oct 5, 2024

Branch updated. Passed tests on my local system (not in docker, which I do not have running properly on this laptop).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torstenroeder torstenroeder torstenroeder left review comments

@GusRiva GusRiva Awaiting requested review from GusRiva

Assignees

@ebeshero ebeshero

Labels
TEI: Guidelines & Documentation Type: Bug
Projects
None yet
Milestone
Guidelines 4.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sydb @ebeshero @torstenroeder